Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(check/lsp): support "compilerOptions.rootDirs" #27844

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Jan 27, 2025

Upstream: denoland/deno_config#152.

Closes #26871.

Cargo.toml Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn added this to the 2.2.0 milestone Jan 28, 2025
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, but yeah needs an integration test.

{
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better👍

@nayeemrmn nayeemrmn requested a review from dsherret January 28, 2025 23:31
@nayeemrmn
Copy link
Collaborator Author

@dsherret PTAL

Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nayeemrmn nayeemrmn merged commit 0dd334b into denoland:main Jan 30, 2025
18 checks passed
@nayeemrmn nayeemrmn deleted the root-dirs branch January 31, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rootDirs and SvelteKit
3 participants