fix(ext/node): do not apply socket-init-workaround to ipc socket #27779
Conversation
| import { chromium } from "npm:playwright"; | ||
| await chromium.launch(); | ||
| console.log("chromium launched"); |
There was a problem hiding this comment.
Does this actually work on CI?
There was a problem hiding this comment.
I suppose so. The first step in this test run -A npm:playwright install chromium should be downloading the chromium for the corresponding platform.
There was a problem hiding this comment.
If it's not cached already, it's worth looking into caching the chromium artifact.
There was a problem hiding this comment.
Added browser binary cache at key playwright-${{ runner.os }}-${{ runner.arch }}
Looks it's been saved successfully
https://github.com/denoland/deno/actions/runs/12984044432/job/36206262673
kt3k
force-pushed
the
fix-playwright-browser-launch
branch
from
6c67bbb to
2ef49be
Compare
|
Do you know when this will be part of an official release? Thank you! |
|
In 2.2 next week. You can upgrade to canary in the meantime ( |
|
Amazing! Thanks! |
) This PR resolves 2 issues of Socket class of node compat (both are related to playwright) Currently `browser.launch()` of playwright is not working. `browser.launch` opens PipeTransport (which is based on Pipe/IPC socket) with the browser process. But that pipe doesn't start reading the data because of the workaround #27662 (which pauses the socket at the beginning if it's from playwright-core). This PR fixes this issue by checking whether the given handle is `ipc` handle or not. Another issue is that sock-init-workaround for TLS connection stopped working at #27707 because of the changes of TLS socket initialization steps. This change fixes the issue by correctly returning the function in workaround path. The added case `specs::npm::playwright_compat` checks both fixes with actual playwright and playwright-core packages. `browser.launch` issues closes #16899 closes #27623 `https.request` issue closes #27658
This PR resolves 2 issues of Socket class of node compat (both are related to playwright)
Currently
browser.launch()of playwright is not working.browser.launchopens PipeTransport (which is based on Pipe/IPC socket) with the browser process. But that pipe doesn't start reading the data because of the workaround #27662 (which pauses the socket at the beginning if it's from playwright-core). This PR fixes this issue by checking whether the given handle isipchandle or not.Another issue is that sock-init-workaround for TLS connection stopped working at #27707 because of the changes of TLS socket initialization steps. This change fixes the issue by correctly returning the function in workaround path.
The added case
specs::npm::playwright_compatchecks both fixes with actual playwright and playwright-core packages.browser.launchissuescloses #16899
closes #27623
https.requestissuecloses #27658