-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global request / response #2253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Also add the new js and d.ts files to //cli/BUILD.gn (otherwise you'll get an appveyor error)
@kitsonk can you give this patch a review if you have time?
@kitsonk I added a new dependency to third_party and made a PR for it, it builds + passes when I use that branch: denoland/deno_third_party#43 |
@mrkurt I pushed an update to third_party with your commit. |
@mrkurt CI is stuck on lint. Run "tools/lint.py" to see the output:
|
@ry Lint is passing now! Appveyor is not loving that submodule conflict though. |
@mrkurt I squashed and force pushed to your branch. let's see if this works. |
public credentials?: "omit" | "same-origin" | "include"; | ||
public headers: domTypes.Headers; | ||
|
||
constructor(input: domTypes.RequestInfo, init?: domTypes.RequestInit) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not:
constructor(input: domTypes.RequestInfo, init: domTypes.RequestInit = {}) {
as
if (!init) { init = {}; }
follows?
u === "HEAD" || | ||
u === "OPTIONS" || | ||
u === "POST" || | ||
u === "PUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about PATCH
?
@mrkurt Maybe fixed now. I pushed a change (and rebased again) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we can do the response in another PR. Thanks!
This is a PR for #2108.
For context, these are ports of the
Request
andResponse
classes from github.com/superfly/flytodo:
Request
implementation + testsBody
mixin + testsResponse
implementation + teststo-maybe-do in a later PR:
ReadableStream
,WritableStream
,TransformStream
fetch.ts
response implementation