Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute path resolution from remote module #2109

Merged
merged 1 commit into from
Apr 13, 2019

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 13, 2019

This PR fixes the absolute path resolution from the remote module.


closes #203


With this change, jspm seems working:

$ cat test.ts 
import React from "https://dev.jspm.io/react";
console.log(React);
$ ./target/debug/deno --reload test.ts 
Compiling file:///Users/kt3k/s/deno/test.ts
Downloading https://dev.jspm.io/react
Downloading https://dev.jspm.io/npm:[email protected]/index.dew.js
Downloading https://dev.jspm.io/npm:[email protected]/cjs/react.development.dew.js
Downloading https://dev.jspm.io/npm:object-assign@4?dew
Downloading https://dev.jspm.io/npm:prop-types@15/checkPropTypes?dew
Downloading https://dev.jspm.io/npm:[email protected]/cjs/react.development.dew.js
Downloading https://dev.jspm.io/npm:object-assign@4?dew
Downloading https://dev.jspm.io/npm:prop-types@15/checkPropTypes?dew
Downloading https://dev.jspm.io/npm:[email protected]/index.dew.js
Downloading https://dev.jspm.io/npm:[email protected]/checkPropTypes.dew.js
Downloading https://dev.jspm.io/npm:[email protected]/lib/ReactPropTypesSecret.dew.js
Downloading https://dev.jspm.io/npm:[email protected]/lib/ReactPropTypesSecret.dew.js
Downloading https://dev.jspm.io/react
Downloading https://dev.jspm.io/npm:[email protected]/index.dew.js
Downloading https://dev.jspm.io/npm:[email protected]/cjs/react.development.dew.js
Downloading https://dev.jspm.io/npm:object-assign@4?dew
Downloading https://dev.jspm.io/npm:[email protected]/index.dew.js
Downloading https://dev.jspm.io/npm:prop-types@15/checkPropTypes?dew
Downloading https://dev.jspm.io/npm:[email protected]/checkPropTypes.dew.js
Downloading https://dev.jspm.io/npm:[email protected]/lib/ReactPropTypesSecret.dew.js
{ Children, createRef, Component, PureComponent, createContext, forwardRef, lazy, memo, useCallback, useContext, useEffect, useImperativeHandle, useDebugValue, useLayoutEffect, useMemo, useReducer, useRef, useState, Fragment, StrictMode, Suspense, createElement, cloneElement, createFactory, isValidElement, version, unstable_ConcurrentMode, unstable_Profiler, __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED }

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 635ad2a into denoland:master Apr 13, 2019
@kt3k kt3k deleted the feature/absolute-path-from-remote branch April 14, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import with absolute path?
2 participants