Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/napi): property with getter/setter always failed #19562

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix(cli/napi): property with getter/setter always failed #19562

merged 1 commit into from
Jun 21, 2023

Conversation

DjDeveloperr
Copy link
Contributor

with napi_define_properties.

littledivy
littledivy approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy enabled auto-merge (squash) June 21, 2023 07:42
@littledivy littledivy merged commit c9e4780 into denoland:main Jun 21, 2023
@DjDeveloperr DjDeveloperr deleted the fix/napi_define_properties branch June 21, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DjDeveloperr @littledivy