-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ext/node): add fs open unit test from std #19505
Conversation
added _fs_open_test.ts from deno_std repo added import paths added import modules
@ktfth Can you also add the line |
Also check the command |
@kt3k I can do that, and I have the tool locally installed. Bring some updates soon. |
@kt3k How to call this kind of files? Example: ext:deno_node/_fs/_fs_constants.ts |
added imports for internal modules added test utils added required arguments
…eat/unit-test-fs-open
@kt3k all done, thank you for the dev experience! The team is awesome. |
@kt3k If have something who can I help, let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
added _fs_open_test.ts from deno_std repo
added import paths
added import modules
#17840