Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ext/node): add fs open unit test from std #19505

Merged
merged 18 commits into from
Jun 21, 2023

Conversation

ktfth
Copy link
Contributor

@ktfth ktfth commented Jun 14, 2023

added _fs_open_test.ts from deno_std repo
added import paths
added import modules

#17840

added _fs_open_test.ts from deno_std repo
added import paths
added import modules
@kt3k
Copy link
Member

kt3k commented Jun 15, 2023

@ktfth Can you also add the line _fs_open_test = _fs / _fs_open_test, in cli/tests/integration/node_unit_tests.rs? (like this line https://github.com/denoland/deno/pull/19461/files#diff-f2b43150de49baab72b5591bd99fb549670093e60fe0eafc663594cda5760e9aR22) That is necessary to run this test file in CI. You can validate it by running the command cargo test _fs_open_test which should trigger this test file from cargo command (it might take a long time if you haven't built deno locally)

@kt3k
Copy link
Member

kt3k commented Jun 15, 2023

Also check the command cargo test integration::node_unit_tests::check_test_glob which validates the settings of cli/tests/integration/node_unit_tests.rs, which is currently failing in CI

@ktfth
Copy link
Contributor Author

ktfth commented Jun 15, 2023

@kt3k I can do that, and I have the tool locally installed. Bring some updates soon.

@ktfth
Copy link
Contributor Author

ktfth commented Jun 15, 2023

@kt3k How to call this kind of files? Example:

ext:deno_node/_fs/_fs_constants.ts

@ktfth
Copy link
Contributor Author

ktfth commented Jun 16, 2023

@kt3k all done, thank you for the dev experience! The team is awesome.

@ktfth
Copy link
Contributor Author

ktfth commented Jun 20, 2023

@kt3k If have something who can I help, let me know

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 4e01356 into denoland:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants