Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ext/node): add os_test.ts #19305

Merged
merged 3 commits into from
May 29, 2023
Merged

test(ext/node): add os_test.ts #19305

merged 3 commits into from
May 29, 2023

Conversation

eggpogg
Copy link
Contributor

@eggpogg eggpogg commented May 29, 2023

Part of #17840

I haven't made any changes or additions to the tests themselves, just moved the tests over and updated to match.

@CLAassistant
Copy link

CLAassistant commented May 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bartlomieju
bartlomieju approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @eggpogg!

@bartlomieju bartlomieju merged commit fc6ba92 into denoland:main May 29, 2023
@eggpogg
Copy link
Contributor Author

eggpogg commented May 29, 2023

Thank you for following and reviewing!

@eggpogg eggpogg deleted the test-add-os-test branch May 29, 2023 13:13
@kt3k kt3k mentioned this pull request Jun 28, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eggpogg @CLAassistant @bartlomieju