Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): add http.Server.unref() #19201

Merged
merged 3 commits into from
May 21, 2023
Merged

fix(node): add http.Server.unref() #19201

merged 3 commits into from
May 21, 2023

Conversation

bartlomieju
Copy link
Member

Closes #19113

@bartlomieju bartlomieju marked this pull request as ready for review May 21, 2023 22:14
@bartlomieju bartlomieju requested review from mmastrac, kt3k and dsherret May 21, 2023 22:14
@bartlomieju bartlomieju enabled auto-merge (squash) May 21, 2023 22:33
crowlKats
crowlKats approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 40bda07 into denoland:main May 21, 2023
@crowlKats crowlKats deleted the node_http_server_ref_unref branch May 21, 2023 23:14
@crowlKats crowlKats restored the node_http_server_ref_unref branch May 21, 2023 23:14
@bartlomieju bartlomieju deleted the node_http_server_ref_unref branch May 21, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

@mmastrac mmastrac Awaiting requested review from mmastrac

@kt3k kt3k Awaiting requested review from kt3k

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"node:http" doesn't implement "Server.unref()" API
2 participants
@bartlomieju @crowlKats