Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add nodeModulesDir option to config file #19095

Merged
merged 2 commits into from
May 18, 2023
Merged

feat(cli): add nodeModulesDir option to config file #19095

merged 2 commits into from
May 18, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented May 11, 2023 •
edited
Loading

This adds an option to disable or enable using a local node_modules directory as a project wide setting.

denoland/manual#659

Closes #17930

@bartlomieju bartlomieju added this to the 1.34 milestone May 13, 2023
bartlomieju
bartlomieju approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju mentioned this pull request May 16, 2023
Merged
@dsherret dsherret merged commit 680ae31 into denoland:main May 18, 2023
@dsherret dsherret deleted the feat_node_modules_dir_config_file branch May 18, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.

Add option to disable node_modules in deno.json
2 participants
@dsherret @bartlomieju