fix(lsp): textDocument/references should respect includeDeclaration
#18496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 29, 2023
bartlomieju
approved these changes
Mar 30, 2023
Comment on lines
+156
to
+160
| // todo(dsherret): refactor the rest of the request methods to have | ||
| // methods to call on this struct, then make `RequestMethod` and | ||
| // friends internal | ||
|
|
||
| pub async fn find_references( |
There was a problem hiding this comment.
Good idea, this is much cleaner than constructing requests in-place.
mmastrac
pushed a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while I was writing tests in a separate PR.