test(node/fs): add fs.Dir tests #18463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kt3k
reviewed
Mar 28, 2023
Comment on lines
8
to
9
| import Dir from "ext:deno_node/_fs/_fs_dir.ts"; | ||
| import type Dirent from "ext:deno_node/_fs/_fs_dirent.ts"; |
There was a problem hiding this comment.
ext: only works for the internal Deno code. I think these should be imported like the below:
Suggested change
| import Dir from "ext:deno_node/_fs/_fs_dir.ts"; | |
| import type Dirent from "ext:deno_node/_fs/_fs_dirent.ts"; | |
| import { Dir, type Dirent } from "node:fs"; |
There was a problem hiding this comment.
Thanks for helping out, I have made the changes according to your suggestion.
Please have a look.
kt3k
reviewed
Mar 28, 2023
55 tasks
mmastrac
pushed a commit
that referenced
this pull request
Mar 31, 2023
Co-authored-by: Yoshiya Hinosawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #17840
I haven't made any changes or additions to the tests themselves, just moved the tests over and updated to match.
_fs tests which have been ported: _fs_dir_test.ts