Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ext/node): port _fs tests from std/node #18262

Merged
merged 4 commits into from
Mar 19, 2023
Merged

Conversation

maxedahlgren
Copy link
Contributor

@maxedahlgren maxedahlgren commented Mar 18, 2023

Part of #17840

I haven't made any changes or additions to the tests themselves, just moved the tests over and updated to match.

_fs tests which have not been ported:

  • _fs_writeFile_test.ts
  • _fs_dir_test.ts
  • _fs_dirent_test.ts
  • _fs_open_test.ts
  • _fs_read_test.ts

(Sorry this ended up being quite large, I wasn't sure if it would make sense to break it up somehow)

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2023

CLA assistant check
All committers have signed the CLA.

Remaining:
- _fs_writeFile_test.ts
- _fs_dir_test.ts
- _fs_dirent_test.ts
- _fs_open_test.ts
- _fs_read_test.ts
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@kt3k kt3k merged commit bf149d0 into denoland:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants