Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ext/node): add _fs_access_test.ts and _fs_watch_test.ts #18249

Merged
merged 5 commits into from
Mar 19, 2023
Merged

test(ext/node): add _fs_access_test.ts and _fs_watch_test.ts #18249

merged 5 commits into from
Mar 19, 2023

Conversation

Sanskar531
Copy link
Contributor

This PR ports _fs/_fs_access_test.ts and _fs/_fs_watch_test.ts from std/node.

part of #17840

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kt3k kt3k mentioned this pull request Mar 18, 2023
Closed
55 tasks
@Sanskar531
Copy link
Contributor Author

Hmm.. looks like a flaky test and no changes were made to those test suites. Runs fine locally on linux. Can we retry the pipeline?

@bartlomieju bartlomieju requested a review from kt3k March 19, 2023 00:13
kt3k
kt3k approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 472c06b into denoland:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sanskar531 @CLAassistant @kt3k