Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests for node:async_hooks #18004

Merged
merged 7 commits into from
Mar 17, 2023
Merged

chore: add tests for node:async_hooks #18004

merged 7 commits into from
Mar 17, 2023

Conversation

bartlomieju
Copy link
Member

Closes #17878

@bartlomieju bartlomieju requested review from crowlKats and removed request for crowlKats March 9, 2023 19:00
@crowlKats crowlKats marked this pull request as ready for review March 17, 2023 13:31
@crowlKats crowlKats changed the title [WIP] chore: add tests for node:async_hooks chore: add tests for node:async_hooks Mar 17, 2023
@bartlomieju bartlomieju enabled auto-merge (squash) March 17, 2023 15:34
crowlKats
crowlKats approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 0bc6bf5 into denoland:main Mar 17, 2023
@crowlKats crowlKats deleted the add_tests_for_als branch March 17, 2023 17:54
@Farsen976 Farsen976 mentioned this pull request Mar 17, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats crowlKats approved these changes

Assignees

@crowlKats crowlKats

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncLocalStorage has incorrect behavior
2 participants
@bartlomieju @crowlKats