Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): better error is version is specified after subpath #16131

Merged
merged 4 commits into from
Oct 3, 2022
Merged

fix(npm): better error is version is specified after subpath #16131

merged 4 commits into from
Oct 3, 2022

Conversation

bartlomieju
Copy link
Member

Ref #15960

@bartlomieju bartlomieju requested a review from dsherret October 2, 2022 20:14
@bartlomieju bartlomieju mentioned this pull request Oct 2, 2022
Closed
25 tasks
dsherret
dsherret reviewed Oct 3, 2022
View reviewed changes
cli/node/mod.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju requested a review from dsherret October 3, 2022 16:05
@bartlomieju bartlomieju merged commit 5b097fd into denoland:main Oct 3, 2022
@bartlomieju bartlomieju deleted the npm_error_version_after_subpath branch October 3, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlomieju @dsherret @cjihrig