-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add console count
and time
functions
#1358
Conversation
@@ -351,6 +351,9 @@ export function stringifyArgs( | |||
|
|||
type PrintFunc = (x: string, isErr?: boolean) => void; | |||
|
|||
const countMap = new Map<string, number>(); | |||
const timerMap = new Map<string, number>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be in the Console class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js has no private property (currently), if it is placed inside the Console
class, these variables are accessed by by code outside the class. And these properties will be printed with console.
currently The printFunc
method is rinted and can be used by external code. I think this is a wrong implementation, and this should be refactored in the future.
> console
Console { printFunc: [Function], log: [Function], debug: [Function], info: [Function], dir: [Function], warn: [Function], error: [Function], assert: [Function] }
> console.printFunc
[Function]
> console.printFunc.toString()
function () { [native code] }
> console.printFunc('hello')
hello
undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
- Upgrade V8 to 7.2.502.16 (denoland#1403) - Remove support for extensionless import (denoland#1396) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Remove support for extensionless import (denoland#1396) - Upgrade V8 to 7.2.502.16 (denoland#1403) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358) - runtime arg check `URLSearchParams` (denoland#1390)
- "cargo build" support (denoland#1369 denoland#1296 denoland#1377 denoland#1379) - Remove support for extensionless import (denoland#1396) - Upgrade V8 to 7.2.502.16 (denoland#1403) - make stdout unbuffered (denoland#1355) - Implement `Body.formData` for fetch (denoland#1393) - Improve handling of non-coercable objects in assertEqual (denoland#1385) - Avoid fetch segfault on empty Uri (denoland#1394) - Expose deno.inspect (denoland#1378) - Add illegal header name and value guards (denoland#1375) - Fix URLSearchParams set() and constructor() (denoland#1368) - Remove prebuilt v8 support (denoland#1369) - Enable jumbo build in release. (denoland#1362) - Add URL implementation (denoland#1359) - Add console.count and console.time (denoland#1358) - runtime arg check `URLSearchParams` (denoland#1390)
- "cargo build" support (#1369 #1296 #1377 #1379) - Remove support for extensionless import (#1396) - Upgrade V8 to 7.2.502.16 (#1403) - make stdout unbuffered (#1355) - Implement `Body.formData` for fetch (#1393) - Improve handling of non-coercable objects in assertEqual (#1385) - Avoid fetch segfault on empty Uri (#1394) - Expose deno.inspect (#1378) - Add illegal header name and value guards (#1375) - Fix URLSearchParams set() and constructor() (#1368) - Remove prebuilt v8 support (#1369) - Enable jumbo build in release. (#1362) - Add URL implementation (#1359) - Add console.count and console.time (#1358) - runtime arg check `URLSearchParams` (#1390)
It is a part of #1351