fix(ext/ffi): throw errors instead of panic #13283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DjDeveloperr
requested review from
bartlomieju,
littledivy and
piscisaureus
as code owners
eliassjogreen
approved these changes
Jan 4, 2022
bartlomieju
reviewed
Jan 4, 2022
bartlomieju
reviewed
Jan 5, 2022
There was a problem hiding this comment.
@DjDeveloperr please add expected messages to assertThrows and we can land this PR 👍
littledivy
reviewed
Jan 5, 2022
littledivy
reviewed
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves error message for symbol which could not be found (this has been bugging me when developing FFI related projects...)
closes #13280