fix(ext/crypto) - exportKey JWK for AES/HMAC must use base64url #13264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptographix
requested review from
bnoordhuis,
littledivy and
lucacasonato
as code owners
cryptographix
changed the title
littledivy
approved these changes
Jan 2, 2022
Co-authored-by: Divy Srivastava <[email protected]>
bartlomieju
approved these changes
Jan 4, 2022
bartlomieju
pushed a commit
that referenced
this pull request
Jan 5, 2022
Co-authored-by: Divy Srivastava <[email protected]>
|
@littledivy @bartlomieju is there any reason this merge is failing CI on Deno main branch? |
|
@seanwykes we had an outage that caused several CI failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #13263 by refactoring JWK symmetric-key export (AES/HMAC) to rust, which already uses base64url.