feat(lsp) add code lens for debugging tests #13138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespertheend
requested review from
bartlomieju,
dsherret and
kitsonk
as code owners
|
Please see denoland/vscode_deno#598 for the accompanying implementation for the vscode extension. |
kitsonk
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13130
Existing clients still need to add support for the
{inspect: true}option.I'm not sure what the current state is of the stability of lsp. I noticed a document saying lsp was still experimental and not feature complete, but this got removed when the document was moved to https://deno.land/[email protected]/language_server/overview last week.
Either way this shouldn't break any existing IDE plugins in a significant way. The debug button will simply run the test rather than debug it.