fix(ext/ffi): Use c_char
instead of i8
in op_ffi_cstr_read
for compatibility with aarch64
#13118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
This patch fixes a build error I get when compiling for aarch64 in Linux:
This is caused by
CStr::from_ptr
returning ani8
on aarch64, instead of au8
.Using
std::os::raw::c_char
will handle the underlying type differences (I think).I've compiled with this patch here and it compiles correctly for aarch64.