Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/tools/coverage): Split sources by char index #13114

Merged
merged 1 commit into from
Dec 17, 2021
Merged

fix(cli/tools/coverage): Split sources by char index #13114

merged 1 commit into from
Dec 17, 2021

Conversation

nayeemrmn
Copy link
Collaborator

I think coverage values use char index? Fixes #13111.

bnoordhuis
bnoordhuis approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bartlomieju
bartlomieju requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get a test case before landing it. I will try to come up with a reproduction for a problem observed in deno_std. It seems to involve transpilation and source maps...

@bartlomieju
Copy link
Member

I tried this PR against deno_std and it indeed fixes the problem; however I'm still having trouble coming up with a test that would reproduce the problem.

bartlomieju
bartlomieju approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to land this without a test as it fixes the immediate problem. Coverage tools is due to an overhaul anyway and we should address the tests there.

@bartlomieju bartlomieju merged commit ca1fbdd into denoland:main Dec 17, 2021
@nayeemrmn nayeemrmn deleted the coverage-index-by-chars branch December 20, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage is broken in deno_std
3 participants
@nayeemrmn @bartlomieju @bnoordhuis