Add chmod/chmodSync on *nix (and fix Cargo.toml) #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkassimo
force-pushed
the
fs/chmod
branch
2 times, most recently
from
83d758a to
9d624a6
Compare
J2P
reviewed
Oct 25, 2018
js/chmod_test.ts
Outdated
| testPerm({ write: false }, function chmodSyncPerm() { | ||
| let err; | ||
| try { | ||
| const filename = deno.makeTempDirSync() + "/test.txt"; |
There was a problem hiding this comment.
I think deno.makeTempDirSync() raise a PermissionDenied error.
There was a problem hiding this comment.
Ooops. Thanks for pointing out
|
On windows there are a bunch of errors like this Otherwise looks good! |
Closed
kevinkassimo
force-pushed
the
fs/chmod
branch
from
9625f41 to
4c0c611
Compare
kevinkassimo
force-pushed
the
fs/chmod
branch
from
4c0c611 to
4e12a47
Compare
|
@ry @kevinkassimo can you suggest me what to do next. |
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 27, 2018
- Add URLSearchParams (denoland#1049) - Implement clone for FetchResponse (denoland#1054) - Use content-type headers when importing from URLs. (denoland#1020) - Use checkJs option, JavaScript will be type checked and users can supply JSDoc type annotations that will be enforced by Deno (denoland#1068) - Add separate http/https cache dirs to DENO_DIR (denoland#971) - Support https in fetch. (denoland#1100) - Add chmod/chmodSync on unix (denoland#1088) - Remove broken features: --deps and trace() (denoland#1103) - Ergonomics: Prompt TTY for permission escalation (denoland#1081)
Merged
ry
added a commit
that referenced
this pull request
Oct 27, 2018
- Add URLSearchParams (#1049) - Implement clone for FetchResponse (#1054) - Use content-type headers when importing from URLs. (#1020) - Use checkJs option, JavaScript will be type checked and users can supply JSDoc type annotations that will be enforced by Deno (#1068) - Add separate http/https cache dirs to DENO_DIR (#971) - Support https in fetch. (#1100) - Add chmod/chmodSync on unix (#1088) - Remove broken features: --deps and trace() (#1103) - Ergonomics: Prompt TTY for permission escalation (#1081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #673 (since no updates for quite a while and this is an important fs call)
Implements
chmodandchmodSyncon *nix. (On windows this is noop)Prior art:
os.Chmod(name string, mode FileMode) errorfs.chmod(file, mode, callback);os.chmod(path, mode);std::fs::set_permissions<P: AsRef>(path: P, perm: Permissions) -> Result<()>lchmodis not implemented yet. It seems that Ruststd::fsonly support inspecting symlink metadata, but anyset_permissions/set_modecalls would eventually set the permission of linked file/dir.Also, add
getoptsentry inCargo.toml(forgot to include this in the PR yesterday)