Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): canonicalize coverage dir #10364

Merged
merged 2 commits into from
May 19, 2021
Merged

fix(cli): canonicalize coverage dir #10364

merged 2 commits into from
May 19, 2021

Conversation

caspervonb
Copy link
Contributor

@caspervonb caspervonb commented Apr 25, 2021 •
edited
Loading

@caspervonb caspervonb force-pushed the fix-coverage-canonicalize-collection-directory branch from 7de7670 to f8e4d0d Compare April 25, 2021 13:09
@caspervonb caspervonb marked this pull request as draft April 25, 2021 13:10
@caspervonb
Copy link
Contributor Author

Drafting this for a minute, it needs a test.

@caspervonb caspervonb marked this pull request as ready for review May 11, 2021 10:18
@caspervonb caspervonb mentioned this pull request May 11, 2021
Merged
bartlomieju
bartlomieju approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's make sure it works in deno_std, if not we'll have to revert

@bartlomieju bartlomieju merged commit 42f7667 into denoland:main May 19, 2021
@caspervonb caspervonb deleted the fix-coverage-canonicalize-collection-directory branch May 19, 2021 13:34
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@caspervonb @piscisaureus
fix(cli): canonicalize coverage dir (#10364)
1139ceb
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@caspervonb @piscisaureus
fix(cli): canonicalize coverage dir (#10364)
321bc20
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@caspervonb @piscisaureus
fix(cli): canonicalize coverage dir (#10364)
d0eee59
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@caspervonb @piscisaureus
fix(cli): canonicalize coverage dir (#10364)
df3d878
piscisaureus pushed a commit that referenced this pull request May 31, 2021
@caspervonb @piscisaureus
fix(cli): canonicalize coverage dir (#10364)
2e9bd3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caspervonb @bartlomieju