Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for node:sqlite #24828

Closed
littledivy opened this issue Aug 1, 2024 · 8 comments · Fixed by #27308
Closed

Tracking issue for node:sqlite #24828

littledivy opened this issue Aug 1, 2024 · 8 comments · Fixed by #27308
Labels
node compat

Comments

@littledivy
Copy link
Member

Related #11657

Tracking issue for implementing the node:sqlite API.

Currently experimental - https://nodejs.org/api/sqlite.html
@tracker1
Copy link

Just curious if there's been progress on this? Haven't dug into the 2.0 additions yet.

@BlackAsLight
Copy link

Just curious if there's been progress on this? Haven't dug into the 2.0 additions yet.

I believe they said in the 2.0 live stream that npm:sqlite has been completed but will only be released in Deno if nodejs takes it out of the experimental phase.

@littledivy
Copy link
Member Author

Yes, it will be added once it's stable in Node.js

@littledivy littledivy mentioned this issue Dec 14, 2024
Merged
@karimfromjordan
Copy link

I'm a bit surprised that in this PR #27308 the node:sqlite implementation is barely faster than Node's. I was expecting significant performance improvements because of Deno's FFI.

littledivy added a commit that referenced this issue Jan 28, 2025
@littledivy
feat(ext/node): implement node:sqlite (#27308)
aeac5a6 
Depends on:
- denoland/deno_core#994
- denoland/deno_core#993
- denoland/deno_core#999
- denoland/deno_core#1000
- denoland/deno_core#1001

Closes #24828


![image](https://github.com/user-attachments/assets/396fc8b7-30cb-411c-82bc-2e9e3e6bbb18)

---------

Signed-off-by: Divy Srivastava <[email protected]>
@sant123
Copy link

sant123 commented Jan 29, 2025

@littledivy do you know if sqlite will be under Deno namespace or by node:sqlite import only?

@littledivy
Copy link
Member Author

node:sqlite is currently import only. I don't think there are any plans yet to have a Deno specific API

@easrng
Copy link

easrng commented Jan 30, 2025

If imports are an issue you should be able to get it with process.getBuiltinModule("node:sqlite") tho

@sant123
Copy link

sant123 commented Jan 30, 2025

@easrng nice, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ext/node): implement node:sqlite littledivy/deno
6 participants
@tracker1 @sant123 @easrng @littledivy @BlackAsLight @karimfromjordan