Skip to content

Commit

Permalink
Dont run permission prompt on windows
Browse files Browse the repository at this point in the history
  • Loading branch information
ry committed Oct 26, 2018
1 parent 55fb52c commit 80a9658
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
6 changes: 0 additions & 6 deletions tools/permission_prompt_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ def test_net_no(self):


def permission_prompt_test(deno_exe):
# TODO We currently skip testing the prompt in Windows completely.
# Windows does not support the pty module used for testing the permission
# prompt.
if os.name == 'nt':
return

p = Prompt(deno_exe)
p.warm_up()
p.test_write_yes()
Expand Down
8 changes: 6 additions & 2 deletions tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import sys
from check_output_test import check_output_test
from deno_dir_test import deno_dir_test
from permission_prompt_test import permission_prompt_test
from setup_test import setup_test
from util import build_path, enable_ansi_colors, executable_suffix, run, rmtree
from unit_tests import unit_tests
Expand Down Expand Up @@ -61,7 +60,12 @@ def main(argv):

check_output_test(deno_exe)

permission_prompt_test(deno_exe)
# TODO We currently skip testing the prompt in Windows completely.
# Windows does not support the pty module used for testing the permission
# prompt.
if os.name != 'nt':
from permission_prompt_test import permission_prompt_test
permission_prompt_test(deno_exe)

rmtree(deno_dir)

Expand Down

0 comments on commit 80a9658

Please sign in to comment.