fix(ext/node): DatabaseSync#exec should execute batch statements (#…

…28053) Fixes #28050
denoland · Feb 11, 2025 · 196ceb7 · 196ceb7
1 parent acdc7dc
commit 196ceb7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/ext/node/ops/sqlite/database.rs b/ext/node/ops/sqlite/database.rs
@@ -166,8 +166,7 @@ impl DatabaseSync {
     let db = self.conn.borrow();
     let db = db.as_ref().ok_or(SqliteError::InUse)?;
 
-    let mut stmt = db.prepare_cached(sql)?;
-    stmt.raw_execute()?;
+    db.execute_batch(sql)?;
 
     Ok(())
   }

diff --git a/tests/unit_node/sqlite_test.ts b/tests/unit_node/sqlite_test.ts
@@ -184,3 +184,16 @@ Deno.test("[node/sqlite] applyChangeset across databases", () => {
     { key: 2, value: "world", __proto__: null },
   ]);
 });
+
+Deno.test("[node/sqlite] exec should execute batch statements", () => {
+  const db = new DatabaseSync(":memory:");
+  db.exec(`CREATE TABLE one(id int PRIMARY KEY) STRICT;
+CREATE TABLE two(id int PRIMARY KEY) STRICT;`);
+
+  const table = db.prepare(
+    `SELECT name FROM sqlite_master WHERE type='table'`,
+  ).all();
+  assertEquals(table.length, 2);
+
+  db.close();
+});