Updates to trait systems #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, I have removed the f-prefixed mathematical functions, since the only conflicts were with the `nalgebra` implementations. From now on, we will prefer using `num` traits and building in additional functionality. This also adds several convenience methods for getting the magnitude of EPS and normalized `Vector3` fields using the new `unit` method to avoid requiring `RealField` for this very simple operation. Additionally, several macros are added to make conversion from raw values easier. In the future, trait implementations might be added as well to provide shortcuts to these methods, but that is a WIP.
…est changes in the `Field` trait
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 19.22% 18.95% -0.28%
==========================================
Files 22 22
Lines 4223 4121 -102
==========================================
- Hits 812 781 -31
+ Misses 3411 3340 -71 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update update the
Fieldtrait by removing thenalgebra::RealFieldsubtrait. This also allows for the removal of f-prefixed math methods. Rather than deprecate a ton of methods, I've chosen to just remove them, making this a rather breaking update (although I doubt anyone is using this crate so this is mostly just documentation for my own sake). A similar process was carried out inganesh, so that has also been updated.Other changes
convert!,convert_vec!, andconvert_array!) to make it easier to convert raw values to generics.Event::eps_mag()for getting the magnitude of the EPS vector and a new traitUnitVectorwhich provides a methodunit()that is implemented fornalgebra::Vector3to quickly get a unit vector without needingRealField'snormalize()method.