Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Fantomas Updates #288

Merged
merged 5 commits into from
Dec 21, 2024

Conversation

1eyewonder
Copy link
Contributor

@1eyewonder 1eyewonder commented Dec 15, 2024

Proposed Changes

  1. Update fantomas to the latest version

  2. Add Main.fs files from tests to .fantomasignore. The below code is causing errors with fantomas and thus not being caught. This also prevented us from catching code that needed formatting.

    #if !FABLE_COMPILER
    open Expecto
    
    [<Tests>] //needed for `dotnet test` to work
    #endif
    let allTests = testList "All Tests" [ AsyncSeq.allTests ]
  3. build.fs has been updated to fail on uncaught code formatting errors within the else block.

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an x in the boxes that apply and remove ones that don't apply

  • Bugfix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally

Further Comments

I made it so that the checkFormatCode step fails if we encounter severe errors within Fantomas, however, I can also see why we may not want to fail here as well. I'm open to reverting/updating the build.fs as needed.

@1eyewonder 1eyewonder marked this pull request as ready for review December 15, 2024 21:06
@1eyewonder 1eyewonder mentioned this pull request Dec 15, 2024
4 tasks
@1eyewonder 1eyewonder changed the base branch from v5-2 to master December 16, 2024 02:02
@1eyewonder
Copy link
Contributor Author

Issue created in the Fantomas repo here

@1eyewonder
Copy link
Contributor Author

After discussion on the issue thread above, I will make some quick updates later, so the code is not choking up fantomas

@TheAngryByrd TheAngryByrd merged commit 776cca3 into demystifyfp:master Dec 21, 2024
33 checks passed
@1eyewonder 1eyewonder deleted the v5-2-update-fantomas branch December 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants