-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncValidation #215
Merged
TheAngryByrd
merged 4 commits into
demystifyfp:master
from
1eyewonder:feature/asyncValidation
Jun 21, 2023
Merged
AsyncValidation #215
TheAngryByrd
merged 4 commits into
demystifyfp:master
from
1eyewonder:feature/asyncValidation
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
requested changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Left some feedback on changes needed for this.
Done! Would the next steps be adding documentation in the gitbook folder? |
Yeah some documentation for that would be nice too :) |
TheAngryByrd
approved these changes
Jun 21, 2023
TheAngryByrd
added a commit
that referenced
this pull request
Jun 21, 2023
- [Added AsyncValidation](#215) Credits @1eyewonder
TheAngryByrd
added a commit
that referenced
this pull request
Jun 21, 2023
- [Added AsyncValidation](#215) Credits @1eyewonder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added AsyncValidation functionality per request of #209
Types of changes
What types of changes does your code introduce to FsToolkit.ErrorHandling?
Put an
x
in the boxes that apply and remove ones that don't applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Majority of code was copied from Validation functions and converted to async. I'm sure there are plenty of things I'll need to address on the PR, but I wanted to get the code out there to start the conversation/reviews. I'm more than happy helping on documentation as well, I just figured I'd get a thumbs up on implementation first from the maintainers.