Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth hash service doctrine #33

Merged

Conversation

padmasreegade
Copy link

@padmasreegade padmasreegade commented Sep 18, 2024

Auth Hash Service migration from Laminas to Doctrine

@padmasreegade padmasreegade marked this pull request as draft September 18, 2024 16:40
Copy link
Owner

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one functional inconsistency between the new and old code; I wonder if this is related to your failing test.

module/VuFind/src/VuFind/Db/Service/AuthHashService.php Outdated Show resolved Hide resolved
@padmasreegade padmasreegade marked this pull request as ready for review September 18, 2024 18:06
Copy link
Owner

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @padmasreegade, this is looking (and working) great! I made two small adjustments in commit 590e67c to expedite completion of this since I won't be around to review again for a few days:

1.) In deleteAuthHash, I restored the line to extract an ID from $authHashOrId to ensure that types are predictable.

2.) In deleteExpired, I simplified the concat to just use the table's ID field. The concat was needed in the other table because that table had no auto-incrementing ID... but this one does, so we can do the same thing with less work. :-)

Thanks again for all of the work on this! I look forward to the next one. Please feel free to start a few PRs in parallel while I'm out of town if necessary. Apart from easy-to-resolve conflicts in the plugin managers when obsolete code is deleted, I don't think there should be any significant issues with taking this approach.

@demiankatz demiankatz merged commit 0b04e24 into demiankatz:doctrine Sep 19, 2024
3 of 4 checks passed
@padmasreegade padmasreegade deleted the auth-hash-service-doctrine branch September 19, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants