Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Adminsitrateur, je peux cloner une démarche avec une drop_down_list utilisant un référentiel #11351

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

LeSim
Copy link
Member

@LeSim LeSim commented Feb 20, 2025

sentry , HS

J'ai l'impression qu'il y a un 2e soucis qui semble plus correspondre à la conversation HS :
sentry

Le 1er lien sentry correspond au cas reproductible en local : si on clone une procédure en "mode référentiel", mais qui n'a pas de csv ajouté.

Par contre le 2e sentry, semble correspondre au HelpScout, et la personne ne peut pas du tout accéder à sa procédure et je ne sais pas pourquoi.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (566a275) to head (31a686b).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11351      +/-   ##
==========================================
+ Coverage   81.07%   84.42%   +3.34%     
==========================================
  Files        1214     1214              
  Lines       27254    26949     -305     
  Branches     5052     5127      +75     
==========================================
+ Hits        22097    22752     +655     
+ Misses       5157     4197     -960     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeSim LeSim force-pushed the fix_cloning_procedure_with_referentiel branch from 6348743 to 12d7bcb Compare February 20, 2025 16:52
@tchak tchak force-pushed the fix_cloning_procedure_with_referentiel branch from 12d7bcb to 7b8cd07 Compare February 25, 2025 12:38
@colinux
Copy link
Member

colinux commented Feb 25, 2025

J'ai commenté sur sentry, en regardant les données en base j'ai vu que des admins avait un drop down en mode avancé (donc référentiel) mais sans référentiel et avec une vraie liste manuelle. Ce ne sont pas forcément des clones. Pourtant il y a un validateur mais je ne suis pas parvenu à reproduire le pb. En attendant j'ai corrigé les données en prod en remplaçant drop_down_mode: advanced en simple pour débloquer les admins.

Cf #11363 (avant que je vois cette PR)

@tchak tchak force-pushed the fix_cloning_procedure_with_referentiel branch from 7b8cd07 to 31a686b Compare February 25, 2025 13:30
@tchak tchak marked this pull request as ready for review February 25, 2025 13:40
@tchak tchak enabled auto-merge February 27, 2025 14:20
@tchak tchak added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
@tchak tchak added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
@tchak tchak merged commit 0af8002 into main Feb 27, 2025
18 checks passed
@tchak tchak deleted the fix_cloning_procedure_with_referentiel branch February 27, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: En cours
Development

Successfully merging this pull request may close these issues.

3 participants