Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixe le lien non cliquable dans les emails lors de l'ajout d'un instructeur #11330

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

kara22
Copy link
Contributor

@kara22 kara22 commented Feb 18, 2025

fix #11217

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (c12440c) to head (d63cad9).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11330   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files        1214     1214           
  Lines       26720    26720           
  Branches     5063     5063           
=======================================
  Hits        22571    22571           
  Misses       4149     4149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kara22 kara22 requested a review from LeSim February 18, 2025 08:13
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, néanmoins, j'ai l'impression que tu n'utilises pas ici les fonctionnalités de pluralisation apporté par le framework (voir https://guides.rubyonrails.org/i18n.html#pluralization).

J'ai l'impression que tu devrais pouvoir filer un .size à t('email_body', count: ...) pour qu'il choisisse lui mm le singulier ou le pluriel.

@kara22 kara22 force-pushed the fix-new-instructeur-email-link branch from 304082d to d63cad9 Compare February 18, 2025 10:13
@kara22
Copy link
Contributor Author

kara22 commented Feb 18, 2025

@LeSim c'est ok now

@kara22 kara22 added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@kara22 kara22 added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit fffb65f Feb 18, 2025
18 checks passed
@kara22 kara22 deleted the fix-new-instructeur-email-link branch February 18, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants