Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur je veux pouvoir uploader un referentiel csv de 5 000 lignes (au lieu de 1000 max) #11329

Merged

Conversation

lisa-durand
Copy link
Contributor

@lisa-durand lisa-durand commented Feb 17, 2025

Afin d'augmenter le nb max de lignes du CSV il faut rendre le combobox plus performant.

-> fait dans cette PR #11335
on affiche désormais 200 éléments dans le combobox.

On peut donc augmenter le nb de lignes à 5k pour le referentiel.

Capture d’écran 2025-02-18 à 16 15 48

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.47%. Comparing base (7cc8916) to head (0f0ee73).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...llers/administrateurs/types_de_champ_controller.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11329      +/-   ##
==========================================
- Coverage   84.47%   84.47%   -0.01%     
==========================================
  Files        1214     1214              
  Lines       26720    26721       +1     
  Branches     5063     5063              
==========================================
  Hits        22572    22572              
- Misses       4148     4149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lisa-durand lisa-durand force-pushed the improve-combobox-usability-for-dropdown-with-many-items-ldu branch from 5defdff to 8269be0 Compare February 18, 2025 13:29
@lisa-durand lisa-durand changed the title ETQ instructeur je veux pouvoir uploader un referentiel csv de 3000 lignes (au lieu de 1000 max) ETQ instructeur je veux pouvoir uploader un referentiel csv de 10 000 lignes (au lieu de 1000 max) Feb 18, 2025
@lisa-durand lisa-durand force-pushed the improve-combobox-usability-for-dropdown-with-many-items-ldu branch from 8269be0 to fd13d1b Compare February 18, 2025 15:14
@lisa-durand lisa-durand changed the title ETQ instructeur je veux pouvoir uploader un referentiel csv de 10 000 lignes (au lieu de 1000 max) ETQ instructeur je veux pouvoir uploader un referentiel csv de 5 000 lignes (au lieu de 1000 max) Feb 18, 2025
@lisa-durand lisa-durand force-pushed the improve-combobox-usability-for-dropdown-with-many-items-ldu branch from fd13d1b to 0f0ee73 Compare February 18, 2025 15:26
@lisa-durand lisa-durand marked this pull request as ready for review February 18, 2025 15:27
@lisa-durand lisa-durand added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit a3883cf Feb 19, 2025
18 checks passed
@lisa-durand lisa-durand deleted the improve-combobox-usability-for-dropdown-with-many-items-ldu branch February 19, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants