Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Utilisateur d'un lecteur d'écran, je veux que les boutons de suppression d'un bloc répétables aient des intitulés différents #11324

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

inseo
Copy link
Contributor

@inseo inseo commented Feb 17, 2025

Fix partiellement #11278

Après
Capture d’écran 2025-02-17 à 15 19 22

Avant
Capture d’écran 2025-02-17 à 15 18 20
Capture d’écran 2025-02-17 à 14 54 48

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (c12440c) to head (fd86439).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11324   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files        1214     1214           
  Lines       26720    26720           
  Branches     5063     5063           
=======================================
  Hits        22571    22571           
  Misses       4149     4149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -7,5 +7,5 @@
= render section_component

.flex.row-reverse
= render NestedForms::OwnedButtonComponent.new(formaction: champs_repetition_path(@dossier, @type_de_champ.stable_id, row_id:), http_method: :delete, opt: { class: "fr-btn fr-btn--sm fr-btn--tertiary fr-text-action-high--red-marianne utils-repetition-required-destroy-button", title: t(".delete_title", row_number:)}) do
= render NestedForms::OwnedButtonComponent.new(formaction: champs_repetition_path(@dossier, @type_de_champ.stable_id, row_id:), http_method: :delete, opt: { class: "fr-btn fr-btn--sm fr-btn--tertiary fr-text-action-high--red-marianne utils-repetition-required-destroy-button", title: t(".delete_title", row_number:), "aria-label": t(".delete_label", row_number:)}) do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plusieurs techniques peuvent être utilisées pour nommer un bouton.
Lorsque plusieurs techniques sont conjointement utilisées sur un même bouton (comme la présence d'une valeur entre les balises button et d'un attribut title), le calcul du « nom accessible », c’est-à-dire ce qui sera restitué, obéit à un ordre strict :

  • aria-labelledby ;
  • Sinon aria-label ;
  • Sinon value pour le cas des input de type submit, reset ou button ;
  • Sinon le contenu de la balise <button> ;
  • Sinon title.

Source : Glossaire RGAA

@inseo inseo added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 673d29a Feb 18, 2025
18 checks passed
@inseo inseo deleted the a11y-delete-button-repeatable-block branch February 18, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Communiqué, ou a ne pas communiqué
Development

Successfully merging this pull request may close these issues.

2 participants