fix(dossier): always use update path to editable dossier #11235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11235 +/- ##
==========================================
- Coverage 84.42% 84.40% -0.02%
==========================================
Files 1199 1199
Lines 26381 26381
Branches 4965 4965
==========================================
- Hits 22271 22268 -3
- Misses 4110 4113 +3 ☔ View full report in Codecov by Sentry. |
|
ça corrige une erreur en particulier ? (j'essaie de faire le ménage sur sentry, y a eu pas mal de nouveaux trucs) ' |
3 tasks
mfo
reviewed
Jan 28, 2025
| @@ -6,7 +6,7 @@ | |||
| .dossier-edit.fr-container.counter-start-header-section | |||
| = render partial: "shared/dossiers/submit_is_over", locals: { dossier: dossier } | |||
| = render NestedForms::FormOwnerComponent.new | |||
| = form_for dossier_for_editing, url: brouillon_dossier_url(dossier), method: :patch, html: { id: 'dossier-edit-form', class: 'form', multipart: true, novalidate: 'novalidate' } do |f| | |||
| = form_for dossier_for_editing, url: brouillon_dossier_url(dossier_for_editing), method: :patch, html: { id: 'dossier-edit-form', class: 'form', multipart: true, novalidate: 'novalidate' } do |f| | |||
There was a problem hiding this comment.
on est d'accord que c'est juste du cosmétique ?
- côté serveur, on adaptait bien par default si
dossier.en_construction?on prend le fork, sinon le dossier - et de tte maniere, l'autosave se declenche sur le champ, qui lui etait le bon car on passe par dossier_for_editing
There was a problem hiding this comment.
Oui, mais à terme ça permettra de simplifier le code
mfo
approved these changes
Jan 28, 2025
|
Non, c'est juste du nettoyage pour préparer la migration vers les streams |
Merged
via the queue into
demarches-simplifiees:main
with commit Jan 28, 2025
ef00646
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.