Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETQ instructeur] je retrouve les labels dans les exports #11209

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

lisa-durand
Copy link
Contributor

Suite de la PR sur les labels afin de les rendre disponible à l'export.
Capture d’écran 2025-01-14 à 16 59 40

J'en ai profité pour faire une petite correction d'alignement repérée par @marleneklok.
Le DSFR ajoute une marge en bas lorsqu'il y a plusieurs tags, j'ai donc rajouté une marge haute pour garder les labels centrés dans le tableau.
APRES
Capture d’écran 2025-01-14 à 17 00 51

AVANT
Capture d’écran 2025-01-14 à 17 01 10

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (48fccd6) to head (7e49823).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
app/models/columns/dossier_column.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11209      +/-   ##
==========================================
- Coverage   84.55%   84.55%   -0.01%     
==========================================
  Files        1196     1196              
  Lines       26300    26302       +2     
  Branches     4962     4963       +1     
==========================================
+ Hits        22239    22240       +1     
- Misses       4061     4062       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trop bien, peu de code et boum ca marche.

@lisa-durand
Copy link
Contributor Author

Trop bien, peu de code et boum ca marche.

Il y a surement qq'un qui a mis en place une bonne structure pour les colonnes au préalable :)

@lisa-durand lisa-durand added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 7d4f814 Jan 16, 2025
18 checks passed
@lisa-durand lisa-durand deleted the add-labels-to-export-ldu branch January 16, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants