Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur, je souhaite avoir des bordures sur mon tableau d'instructeur qu'importe le niveau de zoom #11085

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Nov 25, 2024

probleme

GouvernementFR/dsfr#1050

solution

la solution est simple,
au chargement de la page, on check le niveau de zoom (a travers de devicePixelRatio qui s'adapte fonction du niveau de zoom) pour ajouter une règle CSS dynamiquement proposant une taile de pixel adapté pour ne pas le perdre.

compromis

on ne cherche pas a suivre e niveau de zoom (semble y avoir des APIs, mais on va pas y passer trop de temps non plus, qu'en pensez-vous ?)

@mfo mfo force-pushed the US/fix-border-size-offset branch from d153222 to ca70603 Compare November 25, 2024 16:09
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (0c6dbc8) to head (16ee0ca).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11085   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files        1173     1174    +1     
  Lines       25901    25916   +15     
  Branches     4888     4892    +4     
=======================================
+ Hits        21849    21862   +13     
- Misses       4052     4054    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…epends on page zoom level] so we do not lose table cell borders
@mfo mfo force-pushed the US/fix-border-size-offset branch from 295258b to 16ee0ca Compare November 25, 2024 16:58
@mfo mfo added this pull request to the merge queue Nov 26, 2024
Merged via the queue into demarches-simplifiees:main with commit 2bc516a Nov 26, 2024
18 checks passed
@mfo mfo deleted the US/fix-border-size-offset branch November 26, 2024 09:04
Copy link

sentry-io bot commented Nov 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Load failed delegateEvent(app/javascript/shared/utils) View Issue
  • ‼️ FileUploadError: Error storing file. Uploader.start(app/javascript/shared/activestor... View Issue
  • ‼️ FileUploadError: Impossible d'associer le fichier (in english: error attaching file).' Uploader.start(app/javascript/shared/activestor... View Issue
  • ‼️ TypeError: Illegal constructor FixTableBorderController.connect(app/javascript... View Issue
  • ‼️ FileUploadError: Error creating file. Uploader.start(app/javascript/shared/activestor... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants