Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Instructeur je peux prévisualiser le formulaire d'une démarche #11083

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Nov 25, 2024

Dans la nouvelle nav, il manquait la route dédiée aux instructeurs.

Capture d’écran 2024-11-25 à 15 58 32

petite curiosité, contrairement aux admins, on affiche le form de la révision active, donc le dossier for preview peut remonter un dossier existant de l'instructeur ayant été rebasé. Il faut donc gérer un cas supplémentaire pour ne pas afficher le msg "Le champ a été modifié par l'administration" qui n'a pas de sens sur cet écran

@colinux colinux force-pushed the instructeur-can-preview-procedure branch from 5527e9b to c896e4b Compare November 25, 2024 15:04
@colinux colinux force-pushed the instructeur-can-preview-procedure branch from c896e4b to 874f992 Compare November 25, 2024 15:13
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (602680a) to head (874f992).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ts/editable_champ/champ_label_content_component.rb 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11083      +/-   ##
==========================================
- Coverage   84.35%   84.34%   -0.01%     
==========================================
  Files        1174     1174              
  Lines       25916    25926      +10     
  Branches     4892     4896       +4     
==========================================
+ Hits        21862    21868       +6     
- Misses       4054     4058       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@colinux colinux added this pull request to the merge queue Nov 25, 2024
Merged via the queue into demarches-simplifiees:main with commit 5fbb888 Nov 25, 2024
18 checks passed
@colinux colinux deleted the instructeur-can-preview-procedure branch November 25, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants