Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ instructeur, la racine du fil d'ariane devrait renvoyer sur la liste des demarches #11065

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Nov 21, 2024

No description provided.

…am connected as an instructeur, root of breadcrumb returns to instructeur_procedures_path, not root_path which is admin_procedures_path
@mfo mfo changed the title ETQ instructeur, la racine du fil d'arianne devrait renvoyer sur la liste des demarches ETQ instructeur, la racine du fil d'ariane devrait renvoyer sur la liste des demarches Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.36%. Comparing base (9986704) to head (d78faf9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11065   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files        1173     1173           
  Lines       25888    25888           
  Branches     4887     4887           
=======================================
  Hits        21840    21840           
  Misses       4048     4048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est pour le cas où un instructeur a aussi un profil admin, root_path le redirigeait vers la liste de démarches admin ?

@mfo
Copy link
Contributor Author

mfo commented Nov 21, 2024

c'est pour le cas où un instructeur a aussi un profil admin, root_path le redirigeait vers la liste de démarches admin ?

exactement (je l'avais mis ds le commit message ETQ user having an instructeur and an admin, when i am connected as an instructeur, root of breadcrumb returns to instructeur_procedures_path, not root_path which is admin_procedur… …es_path, me fait penser que limite faudrait inliner les commits message ds la description initial)

@mfo mfo added this pull request to the merge queue Nov 21, 2024
Merged via the queue into demarches-simplifiees:main with commit cd98eb8 Nov 21, 2024
18 checks passed
@mfo mfo deleted the US/bad-start-of-breadcrumb-as-an-instructeur branch November 21, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants