Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: valid_action? -> accessible_action? #10874

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

tchak
Copy link
Member

@tchak tchak commented Sep 27, 2024

No description provided.

Copy link

what-the-diff bot commented Sep 27, 2024

PR Summary

  • Upgraded Access Permission Checks in Different View Pages
    • Updated the method used to verify if an action is accessible in different view pages. This change will enhance system security by ensuring only authorized users can perform certain actions.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (2a80091) to head (0ccb188).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10874   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files        1130     1130           
  Lines       25064    25064           
  Branches     4701     4701           
=======================================
  Hits        21228    21228           
  Misses       3836     3836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak force-pushed the deprecated-valid_action branch from 78ee173 to 0ccb188 Compare September 27, 2024 14:39
@tchak tchak added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@tchak tchak added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@tchak tchak added this pull request to the merge queue Sep 27, 2024
Merged via the queue into demarches-simplifiees:main with commit 4830769 Sep 27, 2024
18 checks passed
@tchak tchak deleted the deprecated-valid_action branch September 27, 2024 16:40
Copy link

sentry-io bot commented Oct 2, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **ActionView::Template::Error: undefined method resource' for an instance of Administrate::Page::Collection (ActionView::Templa...** Manager::PublishedProceduresController#index` View Issue
  • ‼️ **ActionView::Template::Error: undefined method resource' for an instance of Administrate::Page::Collection (ActionView::Templa...** Manager::OutdatedProceduresController#index` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants