Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctif: ETQ instructeur, j'aimerais pouvoir modifier mes modèles d'export, meme sur des démarches avec beaucoup de champs #10864

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Sep 24, 2024

hs: https://secure.helpscout.net/conversation/2711019264/2095236/

problème

on envoie des requetes GET ac des URI trop longues, cf: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/414

solution

on envoie des requetes PUT, pas de problème d'URI 😎 (le mec est brillant ! 🤣)

…s not a good option for procedure with a lot of types_de_champ, otherwise we reach http get size limit
Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super bien trouvé ! relou de devoir faire du put alors que sémantiquement on veut faire un get mais pas mieux !

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (cae524b) to head (b117bc9).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10864   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files        1132     1132           
  Lines       25092    25098    +6     
  Branches     4702     4703    +1     
=======================================
+ Hits        21248    21255    +7     
+ Misses       3844     3843    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo
Copy link
Contributor Author

mfo commented Sep 24, 2024

super bien trouvé ! relou de devoir faire du put alors que sémantiquement on veut faire un get mais pas mieux !

on est plus à ça pret je crois. cf: ee19268 😎

@mfo mfo added this pull request to the merge queue Sep 24, 2024
Merged via the queue into demarches-simplifiees:main with commit 0cbb296 Sep 24, 2024
18 checks passed
@mfo mfo deleted the US/fix-export-template-with-lots-of-types-de-champs branch September 24, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants