Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin, explique mieux que l'attestation v1 reste fonctionnelle alors que j'ai accès à la v2 #10858

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Sep 24, 2024

Capture d’écran 2024-09-24 à 10 05 46

@colinux colinux changed the title ETQ admin, explique mieux que l'attestation v1 reste accessible alors que j'ai accès à la v2 ETQ admin, explique mieux que l'attestation v1 reste fonctionnelle alors que j'ai accès à la v2 Sep 24, 2024
Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impec !

.fr-mb-6w
= render Dsfr::AlertComponent.new(state: :info, title: "Nouvel éditeur d’attestation", heading_level: 'h3') do |c|
- c.with_body do
Cette page présente un nouvel éditeur d'attestations, plus flexible et conforme à la charte de l'État.
%br
Copy link
Contributor

@mfo mfo Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idéalement pas de %br car niveau a11y c'est pas top :/ https://stackoverflow.com/questions/32204760/use-of-br-and-accessibility

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bien vu je pà la place

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (5b268ff) to head (e7f5217).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10858      +/-   ##
==========================================
+ Coverage   84.64%   84.68%   +0.03%     
==========================================
  Files        1132     1132              
  Lines       25084    25095      +11     
  Branches     4693     4702       +9     
==========================================
+ Hits        21233    21251      +18     
+ Misses       3851     3844       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinux colinux force-pushed the attestation-v2-better-v1-ording branch from 6f12884 to e7f5217 Compare September 24, 2024 08:18
@colinux colinux added this pull request to the merge queue Sep 24, 2024
Merged via the queue into demarches-simplifiees:main with commit 655e4be Sep 24, 2024
18 checks passed
@colinux colinux deleted the attestation-v2-better-v1-ording branch September 24, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants