Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ administrateur je ne souhatie pas que mes usagers aient une demande de correction suite à un depot de dossier trop ancien #10855

Merged
merged 1 commit into from
Sep 24, 2024
Merged

ETQ administrateur je ne souhatie pas que mes usagers aient une demande de correction suite à un depot de dossier trop ancien #10855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...intenance/resolve_pending_correction_for_dossier_with_invalid_commune_external_id_task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# frozen_string_literal: true

module Maintenance
# this maintenance task should be run due to app/tasks/maintenance/fix_champs_commune_having_value_but_not_external_id_task.rb
# if you have not ran app/tasks/maintenance/fix_champs_commune_having_value_but_not_external_id_task.rb, this task is not required
class ResolvePendingCorrectionForDossierWithInvalidCommuneExternalIdTask < MaintenanceTasks::Task
DEFAULT_INSTRUCTEUR_EMAIL = ENV.fetch('DEFAULT_INSTRUCTEUR_EMAIL') { CONTACT_EMAIL }

Expand All @@ -14,6 +16,8 @@
penultimate_traitement, last_traitement = *dossier_correction.dossier.traitements.last(2)
dossier_correction.resolve!

next if penultimate_traitement.nil? || last_traitement.nil?

Check warning on line 19 in app/tasks/maintenance/resolve_pending_correction_for_dossier_with_invalid_commune_external_id_task.rb

View check run for this annotation

Codecov / codecov/patch

app/tasks/maintenance/resolve_pending_correction_for_dossier_with_invalid_commune_external_id_task.rb#L19 

Added line #L19 was not covered by tests

if last_traitement_by_us?(last_traitement) && last_transition_to_en_construction?(last_traitement, penultimate_traitement)
dossier_correction.dossier.passer_en_instruction(instructeur: current_instructeur) if dossier_correction.dossier.validate(:champs_public_value)
end
Expand All @@ -33,7 +37,7 @@
end

def last_traitement_by_us?(traitement)
traitement.instructeur_email == DEFAULT_INSTRUCTEUR_EMAIL
traitement&.instructeur_email == DEFAULT_INSTRUCTEUR_EMAIL

Check warning on line 40 in app/tasks/maintenance/resolve_pending_correction_for_dossier_with_invalid_commune_external_id_task.rb

View check run for this annotation

Codecov / codecov/patch

app/tasks/maintenance/resolve_pending_correction_for_dossier_with_invalid_commune_external_id_task.rb#L40 

Added line #L40 was not covered by tests
end

def last_transition_to_en_construction?(last_traitement, penultimate_traitement)
Expand Down
Loading