fix(champ): improve row_id validation and remove it during export #10852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchak
changed the title
tchak
force-pushed
the
fix-export-with-row_ids
branch
from
c041ce2 to
b5eb87d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10852 +/- ##
==========================================
- Coverage 84.64% 84.28% -0.37%
==========================================
Files 1132 1132
Lines 25082 25085 +3
Branches 4691 4691
==========================================
- Hits 21231 21143 -88
- Misses 3851 3942 +91 ☔ View full report in Codecov by Sentry. |
mfo
approved these changes
Sep 23, 2024
Merged
via the queue into
demarches-simplifiees:main
with commit Sep 23, 2024
e355848
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.