Tech: utilise des colonnes id dans les ProcedurePresentation
#10850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: app/models/procedure_presentation.rb
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10850 +/- ##
==========================================
+ Coverage 84.68% 84.69% +0.01%
==========================================
Files 1130 1130
Lines 25060 25082 +22
Branches 4704 4706 +2
==========================================
+ Hits 21221 21243 +22
Misses 3839 3839 ☔ View full report in Codecov by Sentry. |
mfo
approved these changes
Sep 23, 2024
tchak
reviewed
Sep 24, 2024
app/models/procedure_presentation.rb
Outdated
| updated_filtered_columns = filtered_columns.dup | ||
| updated_filtered_columns[statut] << { id: column_id, filter: value } | ||
|
|
||
| update(filters: updated_filters, filtered_columns: updated_filtered_columns) |
There was a problem hiding this comment.
pourquoi t'a besoin de continuer d'écrire dans filters ?
There was a problem hiding this comment.
Ah, tu implémenteras que le write ici et le read sera implémenté dans une autre PR ? Donc pour l'instant, tu as besoin des deux, c'est ça ?
tchak
approved these changes
Sep 24, 2024
LeSim
force-pushed
the
add_id_to_column
branch
8 times, most recently
from
010cda2 to
e449a94
Compare
LeSim
force-pushed
the
add_id_to_column
branch
3 times, most recently
from
07dadb2 to
74bb542
Compare
because: - id should be a string as other id - id need procedure_id to allow ColumnType.deserialize(id) -> Column as the columns are built by a procedure
LeSim
force-pushed
the
add_id_to_column
branch
from
74bb542 to
d5a722c
Compare
mfo
reviewed
Oct 16, 2024
Comment on lines
+25
to
+34
| presentation.filters.each do |key, filters| | ||
| raw_columns = filters.map do | ||
| { | ||
| id: make_id(procedure_id, _1['table'], _1['column']), | ||
| filter: _1['value'] | ||
| } | ||
| end | ||
|
|
||
| presentation.send("#{presentation.filters_name_for(key)}=", raw_columns) | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.