-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(maplibre): update #10845
chore(maplibre): update #10845
Conversation
tchak
commented
Sep 20, 2024
- update to use latest maplibre
- use react-aria-components popover
- use DSFR styles
d9ecabe
to
e4886be
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10845 +/- ##
=======================================
Coverage 84.64% 84.64%
=======================================
Files 1132 1132
Lines 25081 25081
Branches 4691 4691
=======================================
Hits 21230 21230
Misses 3851 3851 ☔ View full report in Codecov by Sentry. |
color: $dark-grey; | ||
|
||
&.on, | ||
&:hover { | ||
background-color: rgba(0, 0, 0, 0.05); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ai essayé 2min d'utiliser une combinaison à base de variables à la place d'hardcoder les valeurs, mais on dirait qu'il ya d'autres trucs qui viennent surcharger ces valeurs dans certains cas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il y a du CSS de MapLibre + DSFR + nous... Je me suis pris la tête un peu aussi. Je pense que je referai une autre passe plus tard (il faut que je migre aussi les sliders à react-aria-component + DSFR)
e4886be
to
95176b8
Compare
0321226
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |