Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maplibre): update #10845

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

tchak
Copy link
Member

@tchak tchak commented Sep 20, 2024

  • update to use latest maplibre
  • use react-aria-components popover
  • use DSFR styles

CleanShot 2024-09-20 at 18 23 32@2x

@tchak tchak force-pushed the update-maplibre branch 2 times, most recently from d9ecabe to e4886be Compare September 20, 2024 19:02
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (b1c0b4d) to head (95176b8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10845   +/-   ##
=======================================
  Coverage   84.64%   84.64%           
=======================================
  Files        1132     1132           
  Lines       25081    25081           
  Branches     4691     4691           
=======================================
  Hits        21230    21230           
  Misses       3851     3851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +12 to +17
color: $dark-grey;

&.on,
&:hover {
background-color: rgba(0, 0, 0, 0.05);
}
Copy link
Member

@colinux colinux Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai essayé 2min d'utiliser une combinaison à base de variables à la place d'hardcoder les valeurs, mais on dirait qu'il ya d'autres trucs qui viennent surcharger ces valeurs dans certains cas

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a du CSS de MapLibre + DSFR + nous... Je me suis pris la tête un peu aussi. Je pense que je referai une autre passe plus tard (il faut que je migre aussi les sliders à react-aria-component + DSFR)

@tchak tchak enabled auto-merge September 23, 2024 12:45
@tchak tchak added this pull request to the merge queue Sep 23, 2024
Merged via the queue into demarches-simplifiees:main with commit 0321226 Sep 23, 2024
18 checks passed
@tchak tchak deleted the update-maplibre branch September 23, 2024 13:01
Copy link

sentry-io bot commented Sep 28, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: You must provide a featureId to enter direct_select mode mouseup(app/javascript/components/shared/maplib... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants