Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Merge pull request #10771"" #10842

Merged

Conversation

tchak
Copy link
Member

@tchak tchak commented Sep 20, 2024

No description provided.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (b6aac5f) to head (3429a72).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
app/models/concerns/dossier_champs_concern.rb 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10842      +/-   ##
==========================================
- Coverage   84.64%   84.64%   -0.01%     
==========================================
  Files        1131     1131              
  Lines       25066    25060       -6     
  Branches     4680     4688       +8     
==========================================
- Hits        21218    21211       -7     
- Misses       3848     3849       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tchak tchak force-pushed the revert-du-revert-de-refactoring-champs branch from 1c35d45 to 379f073 Compare September 20, 2024 14:32
…chak/refactor-champs-revert""

This reverts commit 10a1ae5.
@tchak tchak force-pushed the revert-du-revert-de-refactoring-champs branch from 379f073 to 2339a7f Compare September 23, 2024 08:21
@tchak tchak force-pushed the revert-du-revert-de-refactoring-champs branch from 2339a7f to 3429a72 Compare September 23, 2024 08:51
@tchak tchak added this pull request to the merge queue Sep 23, 2024
Merged via the queue into demarches-simplifiees:main with commit 4ab9ef1 Sep 23, 2024
18 checks passed
@tchak tchak deleted the revert-du-revert-de-refactoring-champs branch September 23, 2024 12:35
Copy link

sentry-io bot commented Sep 24, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RuntimeError: Type De Champ 2409598 not found in Revision 149953 (RuntimeError) API::V2::GraphqlController#execute View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants