Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amelioration ETQ tech/ops, on souhaite ne pas avoir d'index non utilisé (et plus maintenu) - bis #10825

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mfo
Copy link
Contributor

@mfo mfo commented Sep 19, 2024

Un autre index qu'on peut dropper

                table                 |                           index                            | index_size | index_scans 
--------------------------------------+------------------------------------------------------------+------------+-------------
 public.traitements                   | index_traitements_on_process_expired                       | 152 MB     |           0

@mfo mfo force-pushed the US/drop-other-unused-indices branch from 5775b8e to 423579c Compare September 19, 2024 15:21
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (b1c0b4d) to head (7adbdaa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10825   +/-   ##
=======================================
  Coverage   84.64%   84.64%           
=======================================
  Files        1132     1132           
  Lines       25081    25082    +1     
  Branches     4691     4691           
=======================================
+ Hits        21230    21231    +1     
  Misses       3851     3851           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfo mfo force-pushed the US/drop-other-unused-indices branch from 423579c to 6ed5630 Compare September 20, 2024 07:52
@mfo mfo changed the title WIP – tech(clean): unused index and column amelioration ETQ tech/ops, on souhaite ne pas avoir d'index non utilisé (et plus maintenu) - bis Sep 20, 2024
@tchak tchak added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 20, 2024
@@ -2,7 +2,7 @@

class Traitement < ApplicationRecord
belongs_to :dossier, optional: false

self.ignored_columns += [:process_expired, :process_expired_migrated]
Copy link
Member

@colinux colinux Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t'es sûr que les colonnes ont été supprimées ?

en fait j'imagine que non, sinon il y aurait pas l'index, du coup si c'est le cas faudrait jouer une migration qui les supprime non?

Copy link
Contributor Author

@mfo mfo Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on met les ignored_columns avant de supprimer les colonnes, cf: https://github.com/ankane/strong_migrations?tab=readme-ov-file#how-it-works (vient de strong migration)

donc pr le moment je pensais juste les ignorer. et prochaine mep, les supprimer (pr pas avoir de desynchro entre les webs)

@mfo mfo force-pushed the US/drop-other-unused-indices branch from 6ed5630 to 7adbdaa Compare September 23, 2024 12:53
@mfo mfo enabled auto-merge September 23, 2024 12:54
@mfo mfo added this pull request to the merge queue Sep 23, 2024
Merged via the queue into demarches-simplifiees:main with commit b9f9255 Sep 23, 2024
19 checks passed
@mfo mfo deleted the US/drop-other-unused-indices branch September 23, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants