-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amelioration ETQ tech/ops, on souhaite ne pas avoir d'index non utilisé (et plus maintenu) - bis #10825
amelioration ETQ tech/ops, on souhaite ne pas avoir d'index non utilisé (et plus maintenu) - bis #10825
Conversation
5775b8e
to
423579c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10825 +/- ##
=======================================
Coverage 84.64% 84.64%
=======================================
Files 1132 1132
Lines 25081 25082 +1
Branches 4691 4691
=======================================
+ Hits 21230 21231 +1
Misses 3851 3851 ☔ View full report in Codecov by Sentry. |
423579c
to
6ed5630
Compare
@@ -2,7 +2,7 @@ | |||
|
|||
class Traitement < ApplicationRecord | |||
belongs_to :dossier, optional: false | |||
|
|||
self.ignored_columns += [:process_expired, :process_expired_migrated] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t'es sûr que les colonnes ont été supprimées ?
en fait j'imagine que non, sinon il y aurait pas l'index, du coup si c'est le cas faudrait jouer une migration qui les supprime non?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on met les ignored_columns avant de supprimer les colonnes, cf: https://github.com/ankane/strong_migrations?tab=readme-ov-file#how-it-works (vient de strong migration)
donc pr le moment je pensais juste les ignorer. et prochaine mep, les supprimer (pr pas avoir de desynchro entre les webs)
6ed5630
to
7adbdaa
Compare
b9f9255
Un autre index qu'on peut dropper