Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ usager, pas d'erreur sur la page stats quand je viens de la page commencer (à cause de la navbar) #10811

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

colinux
Copy link
Member

@colinux colinux commented Sep 17, 2024

Fix https://demarches-simplifiees.sentry.io/issues/5862238397/events/2179d86f7c5348f2b20ab2c919e4a004/?project=1429550

Double correctif :

  • quand on fallback sur le contexte du referrer de la page Commencer, on n'a pas de request donc l'appel à current_user échouerait
  • défini la vraie logique de navbar pour la page statistiques d'une démarche (qui est la même que la page commencer : usager ou anonyme, elles n'héritent pas de UsersController)

Et on rescue au cas où le fallback car c'est du code pas très joli-joli et qu'on veut pas faire échouer la page à cause de ça

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (f999424) to head (79a1d9b).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...pp/controllers/concerns/nav_bar_profile_concern.rb 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10811      +/-   ##
==========================================
- Coverage   84.64%   84.62%   -0.02%     
==========================================
  Files        1131     1131              
  Lines       25065    25072       +7     
  Branches     4685     4683       -2     
==========================================
+ Hits        21216    21218       +2     
- Misses       3849     3854       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinux colinux added this pull request to the merge queue Sep 17, 2024
Merged via the queue into demarches-simplifiees:main with commit 39ebaad Sep 17, 2024
18 checks passed
@colinux colinux deleted the fix-stats-nav-bar branch September 17, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants