Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing expiration after refacto #10808

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix missing expiration after refacto #10808

merged 1 commit into from
Sep 17, 2024

Conversation

mmagn
Copy link
Contributor

@mmagn mmagn commented Sep 17, 2024

No description provided.

LeSim
LeSim approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mais du coup, il te manquerait pas un test ? (je dis ca moi ...)

@mmagn mmagn force-pushed the fix-missing-expiration branch from b1fcc1d to 8384be1 Compare September 17, 2024 12:26
@mmagn mmagn enabled auto-merge September 17, 2024 12:26
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (c902061) to head (8384be1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/fields/jwt_field.rb 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10808      +/-   ##
==========================================
- Coverage   84.64%   84.64%   -0.01%     
==========================================
  Files        1131     1131              
  Lines       25064    25065       +1     
  Branches     4685     4685              
==========================================
  Hits        21216    21216              
- Misses       3848     3849       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmagn mmagn added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit f999424 Sep 17, 2024
18 checks passed
@mmagn mmagn deleted the fix-missing-expiration branch September 17, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSim LeSim LeSim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmagn @LeSim